Re: [Xen-devel] [PATCH] hotplug: add openvswitch script

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

(adding ovs list to this subthread too)
On Thu, 2013-04-18 at 13:19 +0100, Bastian Blank wrote:
> On Thu, Apr 18, 2013 at 12:50:40PM +0100, Ian Campbell wrote:
> > Based on Waldi's RFC at
> > http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html
> >     BRIDGE_NAME[.VLAN][:TRUNK,TRUNK]
> 
> This needs to be BRIDGE_NAME[.VLAN][:TRUNK:TRUNK]. "," is already taken
> as delimiter.

Thanks -- I tested the regex in isolation in a test script and forgot
that it was part of a larger syntax. I've adjusted the commit message.

> > - xenbr0.99
> >      add the VIF to VLAN99 on xenbr0
> - xenbr0:99:100:101
> >      add the VIF to xenbr0 as a trunk port receiving VLANs 99, 100 & 101
> 
> Bastian
> 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Signed-off-by: Bastian Blank <waldi@xxxxxxxxxx>

Thanks!

> 
> > diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
> > index 9402c3f..625b1a4 100644
> > --- a/tools/examples/xl.conf
> > +++ b/tools/examples/xl.conf
> > @@ -9,7 +9,7 @@
> >  #lockfile="/var/lock/xl"
> >  
> >  # default vif script 
> > -#vifscript="vif-bridge"
> > +vifscript="vif-openvswitch"
> 
> Do you really want to change the default in this patch?

Nope, I called this out in my early reply-to-self as a mistake.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel