Re: [Xen-devel] [PATCH 5/8] kexec: extend hypercall with improved load/unload ops

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 17/04/13 13:51, Daniel Kiper wrote:
> On Tue, Apr 16, 2013 at 06:13:07PM +0100, David Vrabel wrote:
>> 
>>      }
>>
>> +    code_page = __map_domain_page(image->control_code_page);
>> +    memcpy(code_page, kexec_reloc, PAGE_SIZE);
> 
> memcpy(code_page, kexec_reloc, kexec_reloc_size);

kexec_reloc_size is absolute symbol and doing this give linker errors.
FWIW, Linux also uses a #define'd value for its similar memcpy.

I have added a link time check that kexec_reloc_size <= PAGE_SIZE.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel