Re: [Xen-devel] [PATCH v8 1/2] xen: introduce vcpu_block and vcpu_block_enable_events

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 23/04/2013 08:23, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>>> On 22.04.13 at 22:00, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
>> On 22/04/2013 18:42, "Stefano Stabellini" <stefano.stabellini@xxxxxxxxxxxxx>
>> wrote:
>> 
>>> Rename do_block to vcpu_block.
>>> 
>>> Move the call to local_event_delivery_enable out of vcpu_block, to a new
>>> function called vcpu_block_enable_events.
>>> 
>>> Use vcpu_block_enable_events instead of do_block throughout in
>>> schedule.c
>> 
>> While you're there, could you make both vcpu_block variants return void?
> 
> And I don't see why vcpu_block_enable_events() needs to
> become non-static...

I must admit that I don't mind, no reason not to make it part of the API of
the scheduler, even if noone else uses it yet. OTOH I don't have a very
strong opinion either way.

 -- Keir

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel