Re: [Xen-devel] [PATCH v3 13/13] xen/arm: initialize virt_timer and phys_timer with the same values on all vcpus

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-04-26 at 15:30 +0100, Stefano Stabellini wrote:
> > Are you sure this is as simple as this?
> > 
> > At the very least I'm surprised that we don't need to consult b->offset
> > anywhere other than at init time, if vcpus are supposed to see a uniform
> > view of time.
> > 
> > Or is it the case that what actually needs to happen is that t->offset
> > goes away and b->offset is used everywhere?
> 
> That would be another (probably better) way of doing it: the only important
> thing is that the start time on both vcpus is the same.

As it stand yes, although I can't help thinking that the virt timer
ought not to be cleverer, and the offset adjusted based on stolen time
or something like that. Otherwise it isn't really distinct from physical
time with holes in it...

But that's a big can-o-worms.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel