Re: [Xen-devel] [RFC 07/29] xen/arm: Create a hierarchical device tree

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/29/2013 04:19 PM, Ian Campbell wrote:

> On Mon, 2013-04-29 at 00:01 +0100, Julien Grall wrote:
>> Add function to parse the device tree and create a hierarchical tree.
>>
>> This code is based on drivers/of/base.c in linux source.
> 
> Do I understand correctly that most of the complex changes here are
> pre-existing Linux code imported into Xen? It informs how much review
> effort I will give it before I just give in and Ack it ;-)

Yes. It's the same for patches 8, 9 and 10. I have just reindent the
code and use xen internal functions.

>> +    np = unflatten_dt_alloc(&mem, sizeof(struct dt_device_node) + allocl,
>> +                            __alignof__(struct dt_device_node));
>> +    if ( allnextpp )
>> +    {
>> +        memset(np, 0, sizeof(*np));
>> +        np->full_name = ((char *)np) + sizeof(struct dt_device_node);
>> +        /* By default dom0 owns the dom0 */
> 
> Is the second dom0 supposed to be something else?

it's "device" :). I will fix it.

>> +        np->used_by = 0;
> 
>> +struct dt_property {
>> +    const char *name;
>> +    u32 length;
>> +    void *value;
>> +    struct dt_property *next;
>> +};
>> +
>> +#define DT_USED_BY_XEN DOMID_INVALID
> 
> There is already a DOMID_XEN which you could use.
> 
> Ian.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel