Re: [Xen-devel] [PATCH] libxl: unconst the event argument to the event_occurs hook. [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH] libxl: unconst the event argument to the 
event_occurs hook."):
> The event is supposed to become owned, and therefore freed, by the application
> and the const prevents this.
> 
> Unfortunately there is no way to remove the const without breaking existing
> callers. The best we can do is use the LIBXL_API_VERSION provisions to remove
> the const for callers who wish only to support the 4.3 API and newer.
> 
> Callers who wish to support 4.2 will need to live with casting away the const.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian.Jackson@xxxxxxxxxx
> Cc: George.Dunlap@xxxxxxxxx
> Cc: Jim Fehlig <jfehlig@xxxxxxxx>
> Cc: Rob Hoes <Rob.Hoes@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Jim Fehlig writes ("Re: [Xen-devel] [PATCH] libxl: unconst the event argument 
to the event_occurs hook."):
> > -/* API compatibility. Only 0x040200 is supported at this time. */
> > +/* API compatibility. */
> >  #ifdef LIBXL_API_VERSION
> > -#if LIBXL_API_VERSION != 0x040200
> > +#if LIBXL_API_VERSION != 0x040200 && LIBXL_API_VERSION != 0x040300
> >  #error Unknown LIBXL_API_VERSION
...
> Should this hunk be in a separate patch? It seems to be introducing a
> new API version :).

Certainly not.  The actual API actually changes in the rest of the
patch.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel