Re: [Xen-devel] [PATCH 2/6] x86/HVM: slightly adjust RTC reset

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.05.13 at 11:27, Tim Deegan <tim@xxxxxxx> wrote:
> At 14:52 +0100 on 29 Apr (1367247135), Jan Beulich wrote:
>> We should clear the interrupt enable flags here, deassert the IRQ, and
>> clear REG_C.
> 
> I'm not sure at all that we should be tinkering with the IE flags here.
> AFAICT this code is called on S3 suspend -- Does a real S3 do that (and
> not reset any of the other RTC registers?

A real S3 might or might not do this, but I have to admit that I
didn't notice that this is being called from other than rtc_init().
The change was meant to serve purely documentation purposes
based on the name of the function (which isn't in line with being
used in the S3 suspend path if real suspend wouldn't do an RTC
reset).

I wonder, however, whether clearing pt_code here is
appropriate then. And resetting pt.source wouldn't seem to
belong here either if we don't mean to really "reset" the RTC -
it's just that it never gets changed to anything else, so its
mis-placement is benign.

> Deasserting the IRQ seems fair enough, though probably as part of the
> ther IRQ-frobbing changes in another patch.

I'm tending towards dropping the patch altogether in the light
of the above.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel