Re: [Xen-devel] [PATCH v6 07/15] xen/arm: compile and initialize vmap

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.05.13 at 13:29, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Fri, 2013-05-03 at 11:51 +0100, Stefano Stabellini wrote:
>>  xen/include/asm-x86/page.h   |    8 ---
>>  xen/include/xen/mm.h         |    7 +++
> 
> These last two are just the movement of the map_pages_to_xen and
> destroy_xen_mappings prototypes. Unless there are objections from Jan or
> Keir I won't let this stop me applying the series.

That's fine with me of course. What puzzles me in this patch is

>--- a/xen/include/asm-arm/page.h
>+++ b/xen/include/asm-arm/page.h
>@@ -58,6 +58,9 @@
> #define DEV_WC        BUFFERABLE
> #define DEV_CACHED    WRITEBACK
> 
>+#define PAGE_HYPERVISOR         (MATTR_MEM)
>+#define MAP_SMALL_PAGES         PAGE_HYPERVISOR
>+

the non-distinct value for MAP_SMALL_PAGES. Do you not
support large pages for any use of map_pages_to_xen()?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel