Re: [Xen-devel] [PATCH v6 02/15] xen/arm: basic PSCI support, implement cpu_on and cpu_off

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-05-03 at 11:51 +0100, Stefano Stabellini wrote:
> +int do_psci_cpu_on(uint32_t vcpuid, register_t entry_point)
> +{
> +    struct vcpu *v;
> +    struct domain *d = current->domain;
> +    struct vcpu_guest_context *ctxt;
> +    int rc;
> +
> +    if ( (vcpuid < 0) || (vcpuid >= MAX_VIRT_CPUS) )
> +        return PSCI_EINVAL;
> +
> +     if ( vcpuid >= d->max_vcpus || (v = d->vcpu[vcpuid]) == NULL )
> +             return PSCI_EINVAL;

Is this indentation a legacy of a previous surrounding if statement? Or
perhaps some stray hard tabs...

> +
> +     if ( (ctxt = alloc_vcpu_guest_context()) == NULL )
> +             return PSCI_DENIED;
> +
> +     memset(ctxt, 0, sizeof(*ctxt));
> +     ctxt->user_regs.pc64 = (u64) entry_point;
> +     ctxt->sctlr = SCTLR_BASE;
> +     ctxt->ttbr0 = 0;
> +     ctxt->ttbr1 = 0;
> +     ctxt->ttbcr = 0; /* Defined Reset Value */
> +     ctxt->user_regs.cpsr = PSR_GUEST_INIT;
> +     ctxt->flags = VGCF_online;
> +
> +     domain_lock(d);
> +     rc = arch_set_info_guest(v, ctxt);
> +     free_vcpu_guest_context(ctxt);
> +
> +     if ( rc < 0 )
> +     {
> +             domain_unlock(d);
> +             return PSCI_DENIED;
> +     }
> +     domain_unlock(d);
> +
> +    vcpu_wake(v);
> +
> +    return PSCI_SUCCESS;
> +}

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel