[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17



On Wed, May 1, 2013 at 09:21:17AM -0700, Matt Wilson wrote:
> On Mon, Apr 29, 2013 at 03:40:13PM +0200, Olaf Hering wrote:
> > Ping
>
> Makes sense.
>
> Acked-by: Matt Wilson <msw@xxxxxxxxxx>
>
> > On Wed, Jan 16, Olaf Hering wrote:
> >
> > > Ping
> > >
> > > On Wed, Dec 05, Olaf Hering wrote:
> > >
> > > > configure uses clock_gettime to check whether -lrt is needed - and don't
> > > > check other functions. With glibc 2.17 clock_gettime is part of libc, so
> > > > use timer_gettime instead, which is in -lrt in old and new versions of
> > > > glibc.
> > > >
> > > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > > > ---
> > > >  configure | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/configure b/configure
> > > > index 904e019..ace3c3e 100755
> > > > --- a/configure
> > > > +++ b/configure
> > > > @@ -1097,7 +1097,7 @@ fi
> > > >  cat > $TMPC <<EOF
> > > >  #include <signal.h>
> > > >  #include <time.h>
> > > > -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
> > > > +int main(void) { struct itimerspec v; timer_t t; return timer_gettime 
> > > > (t, &v); }
> > > >  EOF
> > > >
> > > >  rt=no

At least 2 acked patches were not committed to qemu-traditional before
the RC1 freeze & tag.

The above patch (against qemu-traditional - qemu-upstream is OK) was
acked a couple of days before Friday's RC1 code freeze, but it still
remains uncommitted.  This patch appears to be needed to build
successfully on Ubuntu Server 13.04, as I was unable to build
yesterday's xen-unstable (specifically the qemu-traditional portion)
without the above patch.

Another patch (subject line "Re: [PATCH] qemu-traditional: do not
strip binaries during make install") was also acked on May 1, but
remains uncommitted.

- Eric

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.