Re: [Xen-devel] [PATCH v3] xen/gic: EOI irqs on the right pcpu

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-05-07 at 14:33 +0100, Stefano Stabellini wrote:
> We need to write the irq number to GICC_DIR on the physical cpu that
> previously received the interrupt, but currently we are doing it on the
> pcpu that received the maintenance interrupt. As a consequence if a
> vcpu is migrated to a different pcpu, the irq is going to be EOI'ed on
> the wrong pcpu.
> 
> This covers the case where dom0 vcpu0 is running on pcpu1 for example
> (you can test this scenario by using xl vcpu-pin).
> 
> 
> Changes in v3:
> - use an int rather than a cpumask to store the EOI cpu;
> - adds the eoi cpu to arch_irq_desc.
> 
> Changes in v2:
> - pass virq by value to gic_irq_eoi;
> - EOI the interrupt without any spin locks held and with interrupt
> enabled.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked and applied.

> CC: keir@xxxxxxx

This patch doesn't touch common/x86 code any more so I didn't wait for
Keir's ack.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel