Re: [Xen-devel] [PATCH V2 07/33] xen/arm: Create a hierarchical device tree

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-05-08 at 14:34 +0100, Julien Grall wrote:
> > Which only leaves ones which are both? How many are these? I'm inclined
> > towards suggesting that if they are debug prints which are disabled by
> > default and require a recompile to enable then the person doing the
> > debugging can select whether they care about early or late messages by 
> > #define-ing DEBUG or EARLY_DEBUG or both as required.
> 
> We can't choose at compile time. Early printk function is in init code
> section. So at the end of boot the function will disappear.

Oh, right.

Perhaps something could be conditional on system_state =
SYS_STATE_active, this happens not long before we discard the initial
sections.

> Device tree function could be called after the end of the boot. For the
> moment it's not the case.
> 
> The best solution would be: early_printk is directly handled in console
> as linux does.

That does sound best.

> >> +/**
> >> + * Host device tree
> >> + * DO NOT modify it!
> > 
> > Can it be const?
> 
> No :/. I choose to runtime information in the device tree. It's usefull
> to know if a device is used by Xen or someone else.
> 
> I have just notice that dt_host is only used in domain_build.c to browse
> all the nodes. I can either provide a helper which return the host DT or
> add a function to call a function and recurse on each node.

I think it is OK, I was only wondering if it could be const.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel