Re: [Xen-devel] [PATCH v3] Try to use git commit id if hg changeset is unavailable

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-05-08 at 16:15 +0100, Marek Marczykowski wrote:
> As Xen uses git as primary repository, get git commit id for
> xen_changeset info.
> 
> Changes in v2:
>  - split scm calls into separate script - based on Linux kernel one,
>    with tags handling removed
> 
> Changes in v3:
>  - do not assume tools/scmversion started from the repository toplevel
>    dir - it is actually called from xen/ subdir

I see you did this by removing various checks for .hg and .igt
directories, but this seems a little fragile and doesn't cover
the .scmversion case properly.

The scmversion script already takes an optional source dir, why not just
pass $(XEN_ROOT) ?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel