[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 04/33] xen/arm: Bump early printk internal buffer to 512

On Thu, 2013-05-09 at 15:32 +0100, Julien Grall wrote:
> On 05/08/2013 02:00 PM, Ian Campbell wrote:
> > On Wed, 2013-05-08 at 03:33 +0100, Julien Grall wrote:
> >> When debug is enabled in device tree code, some lines
> >> are bigger than 80 characters.
> >>
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > Although if we can also take steps to not let the line length get too
> > long that would be valuable, I can see 80-100 being tolerable but if we
> > are actually seeing lines with 512 characters that is an issue in its
> > own right. I appreciate you've just picked a "big enough" number and we
> > hopefully aren't seeing anything like 512 in practice.
> It seems, the function printk uses a buffer of 10024.

I suppose the extra 0 is a typo, but even 1024 seems excessive!

> It's mainly when device tree prints full path on each node.

OK, lets leave it for now but maybe at some point think about ways of
shortening these lines since even if we print them they are going to be
wrapped and hard to read. Perhaps indenting children instead of printing
the whole path.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.