Re: [Xen-devel] [PATCH V2 29/33] xen/arm: Add exynos 4210 UART support

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/09/2013 11:13 AM, Ian Campbell wrote:

> On Wed, 2013-05-08 at 03:33 +0100, Julien Grall wrote:
>> +        /* TODO: should be updated */
>> +        /* Baud rate already set: read it out from the divisor latch. */
>> +#if 0
>> +        divisor = (uart->regs[IBRD] << 6) | uart->regs[FBRD];
>> +        uart->baud = (uart->clock_hz << 2) / divisor;
>> +#endif
> 
> Can we drop the #if 0, extending the comment if necessary, or if
> possible drop the whole thing.

I will move this two lines in the comment.

>> +static int __init exynos4210_uart_init(struct dt_device_node *dev,
>> +                                       const void *data)
>> +{
>> +    const struct serial_arm_defaults *defaults = data;
>> +    struct exynos4210_uart *uart;
>> +    int res;
>> +
>> +    if ( (defaults->index < 0) || (defaults->index > 1) )
>> +        return -EINVAL;
>> +
>> +    uart = &exynos4210_com[defaults->index];
>> +
>> +    /* uart->clock_hz  = 0x16e3600; */
>> +    uart->baud      = BAUD_AUTO;//115200;
> 
> Drop the //115200.


Will be fixed in the next patch series.

>> diff --git a/xen/include/asm-arm/exynos4210-uart.h 
>> b/xen/include/asm-arm/exynos4210-uart.h
>> new file mode 100644
>> index 0000000..1527521
>> --- /dev/null
>> +++ b/xen/include/asm-arm/exynos4210-uart.h
>> @@ -0,0 +1,111 @@
>> +/*
>> + * xen/include/asm-arm/exynos4210-uart.h
>> + *
>> + * Common constant definition between ealry printk and the UART driver
> 
> "early"
> 
> If you fix all the above then
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Ian.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel