Re: [Xen-devel] [PATCH V3 09/41] xen/arm: Extend create_xen_entries prototype to take mapping attribute

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-05-10 at 03:17 +0100, Julien Grall wrote:
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> ---
>  xen/arch/arm/mm.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 2836cbb..96297d3 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -631,7 +631,8 @@ enum xenmap_operation {
>  static int create_xen_entries(enum xenmap_operation op,
>                                unsigned long virt,
>                                unsigned long mfn,
> -                              unsigned long nr_mfns)
> +                              unsigned long nr_mfns,
> +                              unsigned int flags)

Please can we call this "attr" or "ai" to reflect the field which it
goes in. Otherwise:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel