[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 1/2] xen/arm: gic_disable_cpu must be called with interrupts disabled

On Wed, 2013-05-01 at 13:25 +0100, Julien Grall wrote:
> On 05/01/2013 12:55 PM, Ian Campbell wrote:
> > On Tue, 2013-04-16 at 14:38 +0100, Julien Grall wrote:
> >> gic_disable_cpu is only called with interrupt disabled.
> >> Use spin_lock instead of spin_lock_irq and check the function is
> >> called with interrupts disabled.
> > 
> > Is this patch still relevant after this change which is now in master?
> Yes. gic_disable is only called by __cpu_disable, and the irq is disabled.
> local_irq_disable();
> gic_disable_cpu();

Thanks, I somehow dropped this from my queue without applying, thanks to
your kick IRL I have now applied.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.