Re: [Xen-devel] [PATCH V3 11/41] xen/arm: Introduce ioremap_attr

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 10 May 2013, Ian Campbell wrote:
> > @@ -59,6 +59,8 @@
> >  #define DEV_CACHED    WRITEBACK
> >  
> >  #define PAGE_HYPERVISOR         (MATTR_MEM)
> 
> I should have noticed this when Stefano's original vmap patch went in
> but this is wrong.
> 
> MATTR_* are Second stage paging attributes (i.e. p2m ones) and are not
> suitable for the Xen first stage page tables.
> 
> MATTR_MEM == 0xf, which I think will be truncated to 0x7 when written to
> the ai field in the PT (which is only 3 bits) and so this is equivalent
> to using WRITEALLOC. I suspect that isn't at all desirable...
> 
> Stefano, can you fix this please?

Yep

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel