Re: [Xen-devel] [PATCH V2] .gitignore: Add vim swap files

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [PATCH V2] .gitignore: Add vim swap files"):
> On 09/05/13 17:17, Julien Grall wrote:
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> >
> > Changes in v2:
> >     - update .hgignore
> 
> Much appreciated.
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> > diff --git a/.hgignore b/.hgignore
> > index 6b432f7..4bd24fc 100644
> > --- a/.hgignore
> > +++ b/.hgignore
> > @@ -11,6 +11,7 @@
> >  .*\.tar\.bz2$
> >  .*\.tar\.gz$
> >  .*~$
> > +.swp$

AIUI the format of .hgignore files is lines containing
implicitly-^-anchored regexps.

So this is wrong.  Please copy the (hideous) syntax of the other
entries.

Furthermore, while it's good to update both ignore files I think it's
fine to update only one of them if that's what's annoying you.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel