[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3] Try to use git commit id if hg changeset is unavailable

On 13.05.2013 15:52, Olaf Hering wrote:
> On Wed, May 08, Marek Marczykowski wrote:
>> +scm_version()
>> +{
>> +    local short
> What is short supposed to do? Looks like a write-only variable.

Some leftover from --short option of kernel script, not used here. But
--save-scmversion option is broken. This should be equivalent for
"xen/tools/scmversion > .scmversion". So either option should be fixed or
removed completely. I vote for fix and do so in the patch (next email).

Best Regards,
Marek Marczykowski
Invisible Things Lab

Attachment: signature.asc
Description: OpenPGP digital signature

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.