Re: [Xen-devel] [PATCH] xen-blk(front|back): Handle large physical sector disks

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.05.13 at 19:47, Stefan Bader <stefan.bader@xxxxxxxxxxxxx> wrote:
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -704,6 +704,13 @@ again:
>                                dev->nodename);
>               goto abort;
>       }
> +     err = xenbus_printf(xbt, dev->nodename, "physical-sector-size", "%u",
> +                         bdev_physical_block_size(be->blkif->vbd.bdev));
> +     if (err) {
> +             xenbus_dev_fatal(dev, err, "writing %s/physical-sector-size",
> +                              dev->nodename);
> +             goto abort;

Failure here should not be fatal (as with any other protocol
extensions).

Beyond that the patch looks good to me.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel