Re: [Xen-devel] [PATCH] Xen/vMCE: remove is_vmce_ready check

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.05.13 at 10:15, Christoph Egger <chegger@xxxxxxxxx> wrote:
> On 13.05.13 18:02, Liu, Jinsong wrote:
>> From 50fbb875fcf567c75fdbc16c64491aa8e72746b9 Mon Sep 17 00:00:00 2001
>> From: Liu Jinsong <jinsong.liu@xxxxxxxxx>
>> Date: Sat, 27 Apr 2013 22:37:35 +0800
>> Subject: [PATCH] Xen/vMCE: remove is_vmce_ready check
>> 
>> Remove is_vmce_ready() check since
>> 1. it's problematic and overkilled: it checks if virq bind to dom0 mcelog
>> driver. That's not correct, since mcelog is just a dom0 driver used to log
>> error info, irrelated to dom0 vmce injection. It's also overkilled, defaulty
>> dom0 disabled mcelog driver, under such case this checking would resulting
>> in system crash:
>> (XEN) MCE: This error page is ownded by DOM 0
>> (XEN) DOM0 not ready for vMCE
>> (XEN) domain_crash called from mcaction.c:133
>> (XEN) Domain 0 reported crashed by domain 32767 on cpu#31:
>> (XEN) Domain 0 crashed: rebooting machine in 5 seconds.
>> (XEN) Resetting with ACPI MEMORY or I/O RESET_REG.
>> 
>> 2. it's redundant: hypervisor in fact has checked
>> 1). whether dom0 vmce ready or not (at inject_vmce()), via checking
>>     vmce trap callback, to make sure vmce injection OK;
>> 2). whether dom0 mcelog driver ready or not (at mce_softirq()), via
>>     virq binding, to make sure error log works;
>> 
>> 3. it's deprecated: for hvm, it checks whether guest vcpu has different
>> virtual family/model with that of host pcpu --> that's deprecated, since
>> vMCE has changed a lot, not bound to host MCE any more.
>> 
>> Signed-off-by: Liu Jinsong <jinsong.liu@xxxxxxxxx>
> 
> Acked-by: Christoph Egger <chegger@xxxxxxxxx>
> 
> P.S.: I like to see this backported to Xen 4.2. However,
> the Xen 4.2 version may need an adaption as point 3. does not
> count for Xen 4.2.

If you think this requires parts to be kept, then please propose a
suitable backport.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel