Re: [Xen-devel] [PATCH] x86/watchdog: Use real timestamps for watchdog timeout

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.05.13 at 12:13, Tim Deegan <tim@xxxxxxx> wrote:
>> > Handling this case it nice, but I wonder whether this patch ought to
>> > detect and report ludicrous NMI rates rather than silently ignoring
>> > them.  I guess that's hard to do in an NMI handler, other than by
>> > adjusting the printk when we crash.
> 
> Actually on second thoughts it's easier: as well as having this patch
> (or near equivalent) to avoid premature watchdog expiry, we cna detect
> the NMI rate in, say, the timer softirq and report if it's gone mad.

I may not get how you imagine this to work, but why would you
assume the timer softirq gets any chance to run anymore with an
absurd NMI rate (or at least get run enough times to prevent the
watchdog to fire)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel