Re: [Xen-devel] [PATCH] xen/arm: Rework the way to compute dom0 DTB base address

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/28/2013 12:19 PM, Ian Campbell wrote:

>>>>      if ( ret < 0 )
>>>>          goto err;
>>>>  
>>>> -    /*
>>>> -     * Put the device tree at the beginning of the first bank.  It
>>>> -     * must be below 4 GiB.
>>>> -     */
>>>> -    kinfo->dtb_paddr = kinfo->mem.bank[0].start + 0x100;
>>>>      if ( kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt) > (1ull << 32) )
>>>
>>> Isn't this check now misplaced?
>>
>>
>> Right. I think we can remove kinfo->dtb_paddr and just check the DTB
>> size is less than 4GiB.
> 
> Is it easy to check for overlap with the kernel and provide a useful
> message in that case?


It's possible :). I will add it in the next version.

-- 
Julien

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel