Re: [Xen-devel] [PATCH v3] drivers/tpm: add xen tpmfront interface

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, May 28, 2013 at 11:40:32AM -0400, Daniel De Graaf wrote:
> This is a complete rewrite of the Xen TPM frontend driver, taking
> advantage of a simplified frontend/backend interface and adding support
> for cancellation and timeouts.  The backend for this driver is provided
> by a vTPM stub domain using the interface in Xen 4.3.
> 
> Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> Acked-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>

.. snip..
> +static void ring_free(struct tpm_private *priv)
> +{
> +     if (!priv)
> +             return;
> +
> +     if (priv->ring_ref)
> +             gnttab_end_foreign_access(priv->ring_ref, 0,
> +                             (unsigned long)priv->shr);
> +     else
> +             free_page((unsigned long)priv->shr);
> +
> +     if (priv->chip && priv->chip->vendor.irq)
> +             unbind_from_irqhandler(priv->chip->vendor.irq, priv);

You are missing:

        if (priv->evtchn != INVALID_EVTCHN)
                xenbus_free_evtchn(priv->xdev, priv->evtchn);

> +
> +     kfree(priv);
> +}
> +

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel