Xen project Mailing List

Re: [Xen-devel] [xen-unstable bisection] complete build-armhf

From: Julien Grall <julien.grall@xxxxxxxxxx>

Date: Thu, 30 May 2013 21:23:10 +0100

Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, keir@xxxxxxx, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, stefano.stabellini@xxxxxxxxxxxxx

Delivery-date: Thu, 30 May 2013 20:23:39 +0000

List-id: Xen developer discussion <xen-devel.lists.xen.org>

Hello, I'm sorry for this compilation breakage :/. I have either an incremental fix: diff --git a/xen/include/asm-arm/early_printk.h b/xen/include/asm-arm/early_printk.h index 03ead23..5f7c529 100644 --- a/xen/include/asm-arm/early_printk.h +++ b/xen/include/asm-arm/early_printk.h @@ -21,11 +21,12 @@ void early_panic(const char *fmt, ...) __attribute__((noreturn)) #else -static inline void early_printk(const char *fmt, ...) - __attribute__((format (printf, 1, 2))) +static inline __attribute__((format (printf, 1, 2))) void +early_printk(const char *fmt, ...) {} -static inline void __attribute__((noreturn)) early_panic(const char *fmt, ...) - __attribute__((format (printf, 1, 2))) + +static inline void __attribute__((noreturn)) +__attribute__((format (printf, 1, 2))) early_panic(const char *fmt, ...) {while(1);} #endif ------------------------------- or the patch rewritten: diff --git a/xen/include/asm-arm/early_printk.h b/xen/include/asm-arm/early_printk.h index b72fce7..5f7c529 100644 --- a/xen/include/asm-arm/early_printk.h +++ b/xen/include/asm-arm/early_printk.h @@ -14,13 +14,20 @@ #ifdef EARLY_PRINTK -void early_printk(const char *fmt, ...); -void early_panic(const char *fmt, ...) __attribute__((noreturn)); +void early_printk(const char *fmt, ...) + __attribute__((format (printf, 1, 2))); +void early_panic(const char *fmt, ...) __attribute__((noreturn)) + __attribute__((format (printf, 1, 2))); #else -static inline void early_printk(const char *fmt, ...) {} -static inline void __attribute__((noreturn)) early_panic(const char *fmt, ...) {while(1);} +static inline __attribute__((format (printf, 1, 2))) void +early_printk(const char *fmt, ...) +{} + +static inline void __attribute__((noreturn)) +__attribute__((format (printf, 1, 2))) early_panic(const char *fmt, ...) +{while(1);} #endif ------------------------------- Cheers, Julien On 05/30/2013 08:59 PM, xen.org wrote: > branch xen-unstable > xen branch xen-unstable > job build-armhf > test xen-build > > Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git > Tree: xen git://xenbits.xen.org/xen.git > > *** Found and reproduced problem changeset *** > > Bug is in tree: xen git://xenbits.xen.org/xen.git > Bug introduced: 54353cae096c19f176417f6d425de0a0f8a71228 > Bug not present: cafdceb66e154f1ac204be935f9030959827bd1f > > > commit 54353cae096c19f176417f6d425de0a0f8a71228 > Author: Julien Grall <julien.grall@xxxxxxxxxx> > Date: Thu May 23 16:05:18 2013 +0100 > > xen/arm: check string format for early_printk > > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > > > For bisection revision-tuple graph see: > > http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.build-armhf.xen-build.html > Revision IDs in each graph node refer, respectively, to the Trees above. > > ---------------------------------------- > Searching for failure / basis pass: > 18035 fail [host=army] / 18033 ok. > Failure / basis pass flights: 18035 / 18033 > Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git > Tree: xen git://xenbits.xen.org/xen.git > Latest e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 1adef1732f67b4039170210bb2e67c64c9dabd4c > Basis pass e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 41abbadef60e5fccdfd688579dd458f7f7887cf5 > Generating revisions with ./adhoc-revtuple-generator > git://xenbits.xen.org/staging/qemu-upstream-unstable.git#e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44-e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > > git://xenbits.xen.org/xen.git#41abbadef60e5fccdfd688579dd458f7f7887cf5-1adef1732f67b4039170210bb2e67c64c9dabd4c > using cache /export/home/osstest/repos/git-cache... > using cache /export/home/osstest/repos/git-cache... > locked cache /export/home/osstest/repos/git-cache... > processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git > /export/home/osstest/repos/xen... > Initialized empty Git repository in /export/home/osstest/repos/xen/ > updating cache /export/home/osstest/repos/git-cache xen... > using cache /export/home/osstest/repos/git-cache... > using cache /export/home/osstest/repos/git-cache... > locked cache /export/home/osstest/repos/git-cache... > processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git > /export/home/osstest/repos/xen... > Initialized empty Git repository in /export/home/osstest/repos/xen/ > updating cache /export/home/osstest/repos/git-cache xen... > Loaded 1001 nodes in revision graph > Searching for test results: > 18039 fail e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 74025300d55262155a3bdafddf257d82dcf0f6af > 18040 pass e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > cafdceb66e154f1ac204be935f9030959827bd1f > 18041 fail e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > b68346247f74e002ef180403167888a03f488080 > 18042 fail e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 54353cae096c19f176417f6d425de0a0f8a71228 > 18043 pass e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > cafdceb66e154f1ac204be935f9030959827bd1f > 18044 fail e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 54353cae096c19f176417f6d425de0a0f8a71228 > 18045 pass e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > cafdceb66e154f1ac204be935f9030959827bd1f > 18046 fail e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 54353cae096c19f176417f6d425de0a0f8a71228 > 18032 pass e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 41abbadef60e5fccdfd688579dd458f7f7887cf5 > 18033 pass e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 41abbadef60e5fccdfd688579dd458f7f7887cf5 > 18035 fail e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 1adef1732f67b4039170210bb2e67c64c9dabd4c > 18036 pass e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 41abbadef60e5fccdfd688579dd458f7f7887cf5 > 18038 fail e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > 1adef1732f67b4039170210bb2e67c64c9dabd4c > Searching for interesting versions > Result found: flight 18032 (pass), for basis pass > Result found: flight 18035 (fail), for basis failure > Repro found: flight 18036 (pass), for basis pass > Repro found: flight 18038 (fail), for basis failure > 0 revisions at e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 > cafdceb66e154f1ac204be935f9030959827bd1f > No revisions left to test, checking graph state. > Result found: flight 18040 (pass), for last pass > Result found: flight 18042 (fail), for first failure > Repro found: flight 18043 (pass), for last pass > Repro found: flight 18044 (fail), for first failure > Repro found: flight 18045 (pass), for last pass > Repro found: flight 18046 (fail), for first failure > > *** Found and reproduced problem changeset *** > > Bug is in tree: xen git://xenbits.xen.org/xen.git > Bug introduced: 54353cae096c19f176417f6d425de0a0f8a71228 > Bug not present: cafdceb66e154f1ac204be935f9030959827bd1f > > using cache /export/home/osstest/repos/git-cache... > using cache /export/home/osstest/repos/git-cache... > locked cache /export/home/osstest/repos/git-cache... > processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git > /export/home/osstest/repos/xen... > Initialized empty Git repository in /export/home/osstest/repos/xen/ > updating cache /export/home/osstest/repos/git-cache xen... > > commit 54353cae096c19f176417f6d425de0a0f8a71228 > Author: Julien Grall <julien.grall@xxxxxxxxxx> > Date: Thu May 23 16:05:18 2013 +0100 > > xen/arm: check string format for early_printk > > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > > Revision graph left in > /home/xc_osstest/results/bisect.xen-unstable.build-armhf.xen-build.{dot,ps,png,html}. > ---------------------------------------- > 18046: tolerable ALL FAIL > > flight 18046 xen-unstable real-bisect [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/18046/ > > Failures :-/ but no regressions. > > Tests which did not succeed, > including tests which could not be run: > build-armhf 4 xen-build fail baseline > untested > > > jobs: > build-armhf fail > > > ------------------------------------------------------------ > sg-report-flight on woking.cam.xci-test.com > logs: /home/xc_osstest/logs > images: /home/xc_osstest/images > > Logs, config files, etc. are available at > http://www.chiark.greenend.org.uk/~xensrcts/logs > > Test harness code can be found at > http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.