[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/2] xen/arm: Rework the way to compute dom0 DTB base address



On 05/31/2013 02:28 PM, Julien Grall wrote:

>>> +    if ( !(MAX(zimage_start, dtb_end) < MIN(zimage_end, dtb_start)) )
>>> +        return 0;
>>
>> I had to draw quite a few pictures to convince myself this was right,
>> and I'm still not entirely sure ;-)
> 
> 
> In fact it's totally wrong :/. What about this check?

>

Another mistake on the first check:

if ( (dtb_start > zimage_end) || (dtb_end < zimage_start) )


-- 
Julien

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.