[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/vtsc: update vcpu_time after hvm_set_guest_time

>>> On 04.06.13 at 11:56, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> On 06/04/2013 10:46 AM, Roger Pau Monnà wrote:
>> Yes, the call in context_switch is now superseded by the one in
>> hvm_do_resume for the HVM case. I will change it and resend the patch,
>> thanks for the review.
> I agree that it's worth trying to avoid calling the same function twice; 
> but since the common case is for pt_restore_timer() to not actually make 
> any substantial changes to hvm_vcpu.stime_offset, I think it would be 
> better if we had the basic "update the system time" call shared between 
> HVM and PV codepaths, and have the uncommon case where 
> hvm_vcpu.stime_offset does change just call it twice.

Makes sense to me.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.