Re: [Xen-devel] [PATCH] x86/vtsc: update vcpu_time after hvm_set_guest_time

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 04/06/13 13:45, Jan Beulich wrote:
>>>> On 04.06.13 at 13:15, Roger Pau MonnÃ<roger.pau@xxxxxxxxxx> wrote:
>> On 04/06/13 11:47, George Dunlap wrote:
>>> You could gate calling update_vcpu_system_time on:
>>> 1. Whether stime_offset actually changed
>>> 2. Whether v is currently running
>>
>> I'm not sure if only updating the vcpu time if the vCPU is running can
>> lead to a slip in the vcpu time update. As an example, if we call
>> hvm_set_guest_time with the vCPU not running and change the offset, and
>> then call it again on resume, but the offset has not changed this time
>> the vcpu time will not be updated.
> 
> But in that case the call from context_switch() would take care
> of it, wouldn't it?

Sure, I just got messed up with what we discussed before about gating
the call to update_vcpu_system_time in context_switch for the HVM case.
Will resend shortly.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel