Re: [Xen-devel] [PATCH v3] x86/vtsc: update vcpu_time in hvm_set_guest_time

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Tue, Jun 4, 2013 at 4:32 PM, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
> When using a vtsc, hvm_set_guest_time changes hvm_vcpu.stime_offset,
> which is used in the vcpu time structure to calculate the
> tsc_timestamp, so after updating stime_offset we need to propagate the
> change to vcpu_time in order for the guest to get the right time if
> using the PV clock.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> ---
> Changes since v2:
>  * Check for v == current instead of v->is_running to know if the vcpu
>    is running.

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

It might not be bad at some point to add an ASSERT() in
__update_vcpu_system_time() that v == current.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel