Re: [Xen-devel] [PATCH RFC 2/4] Implement arch_hvm_save and arch_hvm_load functions

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> diff --git a/xen/include/public/arch-arm/hvm/save.h 
> b/xen/include/public/arch-arm/hvm/save.h
> index 75b8e65..570809e 100644
> --- a/xen/include/public/arch-arm/hvm/save.h
> +++ b/xen/include/public/arch-arm/hvm/save.h
> @@ -26,6 +26,22 @@
>  #ifndef __XEN_PUBLIC_HVM_SAVE_ARM_H__
>  #define __XEN_PUBLIC_HVM_SAVE_ARM_H__
>  
> +/* 
> + * Save/restore header: general info about the save file. 
> + */
> +
> +#define HVM_FILE_MAGIC   0x92385520
> +#define HVM_FILE_VERSION 0x00000001
> +
> +struct hvm_save_header {
> +    uint32_t magic;             /* Must be HVM_FILE_MAGIC */
> +    uint32_t version;           /* File format version */
> +    uint64_t changeset;         /* Version of Xen that saved this file */
> +    uint32_t cpuid;             /* CPUID[0x01][%eax] on the saving machine */

The comment here looks x86 to be specific.

Need to consider whether MIDR is sufficient for the safety check we have
or whether it is appropriate in the header at all, perhaps it should be
in a separate cpu features save header?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel