[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xen-netback stable backports request (regression fixes)

On Wed, Jun 05, 2013 at 09:52:59PM +0100, Ian Campbell wrote:
> On Wed, 2013-06-05 at 13:25 -0700, Greg KH wrote: 
> > > For the first we thought that allocating a variable size array on the
> > > stack was bad practice which could lead to a stack overflow. The default
> > > is safe but can be overridden by a module parameter.
> > > 
> > > The other renames the module parameter which we thought was useful for
> > > consistency between newer kernels and the stable branches.
> > 
> > So you are doing a user/kernel api change in a stable branch?  Heck, you
> > did it in 3.10?  Why?  What did you just break by doing that?  I can't
> > do that to users of the stable kernels, sorry, and you shouldn't be
> > doing that to users of the 3.10 kernel either.  You should rename this
> > back so people's working systems don't break when they upgrade their
> > kernel.
> The module parameter was introduce after 3.9 and then renamed before
> v3.10-rc1 happened, the original name was never part of an -rc let alone
> an actual release.

Ah, ok, my mistake then, I'll go apply this to keep things synced up.

sorry for the confusion, too many patches at once to handle in the
short-term memory...

greg k-h

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.