[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/blkback: Check for insane amounts of request on the ring.

>>> On 05.06.13 at 19:35, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> @@ -230,6 +231,7 @@ static int xen_blkif_map(struct xen_blkif *blkif, 
> unsigned long shared_page,
>  static void xen_blkif_disconnect(struct xen_blkif *blkif)
>  {
>       if (blkif->xenblkd) {
> +             wake_up(&blkif->shutdown_wq);
>               kthread_stop(blkif->xenblkd);
>               blkif->xenblkd = NULL;
>       }

Btw., wouldn't the wake_up() better be done after the kthread_stop(),
so that when the corresponding wait_event_interruptible() checks
whether to exit the terminating kthread_should_stop() is guaranteed
to evaluate to true (otherwise I think there's potential for it to never


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.