Re: [Xen-devel] [PATCH 12/16] libelf: Make all callers call elf_check_broken

[George Dunlap <dunlapg@xxxxxxxxx>]

On Tue, Jun 4, 2013 at 6:59 PM, Ian Jackson <ian.jackson@xxxxxxxxxxxxx> wrote:
> diff --git a/tools/xcutils/readnotes.c b/tools/xcutils/readnotes.c
> index ca86ba5..b868fba 100644
> --- a/tools/xcutils/readnotes.c
> +++ b/tools/xcutils/readnotes.c
> @@ -300,6 +300,9 @@ int main(int argc, char **argv)
>                 printf("__xen_guest: %s\n",
>                         elf_strfmt(&elf, elf_section_start(&elf, shdr)));
>
> +        if (elf_check_broken(&elf))
> +               printf("warning: broken ELF: %s\n", elf_check_broken(&elf));
> +

This seems to have some ghastly combination of spaces and tabs that
make it render strangely if tabsize != 8.  (Understandable as the
whole file is full of tabs...)

Other than that, the changes look good and sensible.  I haven't done a
survey of the code to see what may have been missed, however.

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

 -G

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel