[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

On 07/06/13 14:49, Konrad Rzeszutek Wilk wrote:
On Fri, Jun 07, 2013 at 12:50:41AM +0200, Dario Faggioli wrote:
Commits d0782481 and bec8f17e added these two fields in libxl_physinfo
One usually includes right after the git commit the title
of the patches, so:

d0782481 ("xl: export 'outstanding_pages' value from xcinfo") and
and in libxl_dominfo, respectively, but did not include the needed
LIBXL_HAVE_<foo> runes. Adding them.

Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Besides the above mention commit description part (And one tweak below)
please also add
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

or Acked-by - whichever George is looking for.

Both are good, now that I understand what "reviewed-by" actually means. :-)

BTW, I've been meaning to take a look to see if these are the right thing; but from a release standpoint, obviously these kinds of things are really important, and we should actually go through the libxl interface and see if there are any other bits we need to add something like this for.

So re the release:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

I'll probably come by later and do a proper review.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.