Re: [Xen-devel] [PATCH] hvm/x86: fix x2APIC APIC_ID read emulation

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Jun 09, 2013 at 02:20:04AM +0000, Wangzhenguo wrote:
> >From 769b64a379c9b447cf5ad8a6f93560dedeb26f2a Mon Sep 17 00:00:00 2001
> From: Zhenguo Wang <wangzhenguo@xxxxxxxxxx>
> Date: Sun, 9 Jun 2013 10:08:48 +0800
> Subject: [PATCH] hvm/x86: fix x2APIC APIC_ID read emulation
> 
> APIC and x2APIC have different format for APIC_ID register. Need translation.
> 
> Signed-off-by: Zhenguo Wang <wangzhenguo@xxxxxxxxxx>
> Signed-off-by: Xiaowei Yang <xiaowei.yang@xxxxxxxxxx>
> ---
>  xen/arch/x86/hvm/vlapic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
> index 8c6a7e2..e0f6f06 100644
> --- a/xen/arch/x86/hvm/vlapic.c
> +++ b/xen/arch/x86/hvm/vlapic.c
> @@ -584,6 +584,8 @@ int hvm_x2apic_msr_read(struct vcpu *v, unsigned int msr, 
> uint64_t *msr_content)
>      vlapic_read_aligned(vlapic, offset, &low);
>      if ( offset == APIC_ICR )
>          vlapic_read_aligned(vlapic, APIC_ICR2, &high);
> +    else if ( offset == APIC_ID)
                                  ^
Style problem. Should add one space before closing parenthesis.


Wei.

> +        low = VLAPIC_ID(vlapic);
>  
>      *msr_content = (((uint64_t)high) << 32) | low;
>      return 0;
> --
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel