Re: [Xen-devel] [PATCH 2/2 V2] iommu/amd: Workaround for erratum 787

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.06.13 at 01:13, Suravee Suthikulanit <suravee.suthikulpanit@xxxxxxx> 
>>> wrote:
> We should also check if the EventLogInt and PPRInt bits are set before 
> actually going into the log processing code.

No, I'd prefer to keep that aspect as is, again to be one the safe
side.

> Also, I agree with Jan that we should not need
> to disable the Event log and the PPR log in the IOMMU control register.
> This could be handled simply through the status register.

I also didn't switch that aspect, keeping in mind that your
documentation says otherwise (and, however minor, that the virtual
IOMMU emulation code is implemented with the opposite behavior).
Safest will be to not depend on questionable aspects.

> Also, I think we can further simplify the logic for the workaround by having 
> only
> one loop instead of two.  Here is the newly proposed changes for the patch.  
> However,
> I am still not sure if we should reschedule the tasklet instead of just 
> using the while loop here.

It's re-scheduling the tasklet for all recovery purposes now. Please
take a look at v5 (to be sent right after this mail).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel