Re: [Xen-devel] [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Fri, 2013-06-07 at 15:54 +0200, Dario Faggioli wrote:
> On ven, 2013-06-07 at 06:49 -0700, Konrad Rzeszutek Wilk wrote:
> > On Fri, Jun 07, 2013 at 12:50:41AM +0200, Dario Faggioli wrote:
> > > Commits d0782481 and bec8f17e added these two fields in libxl_physinfo
> > 
> > One usually includes right after the git commit the title
> > of the patches, so:
> > 
> > d0782481 ("xl: export 'outstanding_pages' value from xcinfo") and
> > ...
> >
> Ok, I think I see why that could be useful. Note taken, thanks. :-)
> 
> > > and in libxl_dominfo, respectively, but did not include the needed
> > > LIBXL_HAVE_<foo> runes. Adding them.
> > > 
> > > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > 
> > Besides the above mention commit description part (And one tweak below)
> > please also add
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > 
> > or Acked-by - whichever George is looking for.
> > 
> Ok, thanks again. George, Ian, should I respin incorporating Konrad's
> feedback (both to the changelog and to the code comment, of course)?

Please do.

> Is this fine for being picked up in 4.3?

IMHO Yes.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel