Re: [Xen-devel] [PATCH] xen: fix initialization of wallclock time for PVHVM on migration

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On 11/06/13 18:12, Keir Fraser wrote:
> On 11/06/2013 16:59, "Roger Pau Monné" <roger.pau@xxxxxxxxxx> wrote:
> 
>>> Hmm I can't find any confirmation that my patch actually *did* work. :( I'm
>>> sure I remember testing it though!
>>>
>>> My suggestion is we do indeed remove the inner if() in latch_shinfo_size().
>>> Ie. Call update_domain_wallclock_time() even if shinfo size has apparently
>>> not changed. 
>>>
>>> We only latch shinfo size on hypercall page initialisation and on setup of
>>> the callback irq. They are start-of-day/resume operations, so removing the
>>> if() should have no bad side effect that I can see. If nothing else it
>>> should make this wallclock-field setup more robust.
>>
>> So it would be better to call update_domain_wallclock_time
>> unconditionally on latch_shinfo_size rather than doing it on
>> XENMAPSPACE_shared_info?
>>
>> Conceptially it makes more sense IMHO to do it in the call to
>> XENMAPSPACE_shared_info.
> 
> I would still make the fix in latch_shinfo_size() and perhaps add an extra
> call to latch_shinfo_size() from the call to XENMAPSPACE_shared_info. But
> actually I am sure you will find it unnecessary and at this point for Xen
> 4.3 I think the smallest possible patch wins.

ACK, will resend the patch.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel