[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 18/23] libxc: Add range checking to xc_dom_binloader

George Dunlap writes ("Re: [Xen-devel] [PATCH 18/23] libxc: Add range checking 
to xc_dom_binloader"):
> if ( dom->kernel-size - sizeof(*table) > 8192)
>   ptr_end = dom->kernel_blob + 8192
> else
>   ptr_end = dom->kernel_size - sizeof(*table);
> Or something along those lines?

Yes, I said something similar to Chuck.  Except that your code has a
bug if kernel_size < sizeof(*table) :-).

TBH I think I'd rather not disturb this any more than necessary.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.