Re: [Xen-devel] pygrub patch to allow explicit offset to fs

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 19/06/13 09:17, Ian Campbell wrote:
> On Wed, 2013-06-19 at 01:40 +0200, Kjetil Torgrim Homme wrote:
> > I recently needed an old VM to work even though it was created on a SAN
> > LUN with no partition table, just LVM straight onto the raw device.
> >
> > pygrub didn't like this, so I added a simple hack to allow the user to
> > override pygrub's probing when necessary.  please consider applying this
> > patch.  btw, I think most LVM will have first filesystem at offset 196608.
> >
> >
> > commit 80a3f7b48da235695f8560deb41c19b23e7799e3
> > Author: Kjetil Torgrim Homme <kjetil.homme@xxxxxxxxxxxxxxxxxx>
> > Date:   Wed Jun 19 00:54:43 2013 +0200
> >
> >       allow user to specify offset parameter which overrides partition
> > table parsing
> >
> >       Signed-off-by: Kjetil Torgrim Homme <kjetil.homme@xxxxxxxxxxxxxxxxxx>
> Looks good to me, thanks.
>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> although I've suggested a possible simplification below.
>
> I think with the freeze being in force this, as a new feature, will have
> to wait for the 4.4 dev cycle to be applied, although I will defer to
> George's judgement.
Yeah, I think this will have to wait.  It does also touch a codepath 
used by people not using this feature, and so there is ever so slight a 
chance that there will be breakage.
 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel