[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments

On 21/06/13 09:34, George Dunlap wrote:
On 20/06/13 18:06, Stefano Stabellini wrote:
On Thu, 20 Jun 2013, George Dunlap wrote:
The printf() available to hvmloader does not handle 64-bit data types;
manually break them down as two 32-bit strings.

Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
CC: Hanweidong <hanweidong@xxxxxxxxxx>
CC: Keir Fraser <keir@xxxxxxx>
What's the issue with implementing %llx?

It involves implementing __udiv64(), since hvmloader runs in 32-bit mode.

Actually, it looks like hvmloader already does have a "divide 64-bit by 32-bit" function I could use; but that would be a more significant change in functionality in the paths that are run by basically everyone, rather than minimal changes for people not affected by the bug and major changes only for people who are going to crash anyway.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.