[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 1/8] hvmloader: Remove all 64-bit print arguments

On 21/06/2013 11:48, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> George Dunlap writes ("[PATCH v4 1/8] hvmloader: Remove all 64-bit print
> arguments"):
>> The printf() available to hvmloader does not handle 64-bit data types;
>> manually break them down as two 32-bit strings.
>> v4:
>>  - Make macros for the requisite format and bit shifting
> This is an improvement.
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

I like it because it makes it easy to go implement %llx properly later. I
think it's dumb we're not doing that now to be honest, we have code in Xen
that could be pinched.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.