Re: [Xen-devel] [PATCH] tools/libxc: Fix memory leaks in xc_domain_restore()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 21/06/13 18:27, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH] tools/libxc: Fix memory leaks in 
> xc_domain_restore()"):
>> tools/libxc: Fix memory leaks in xc_domain_restore()
>> +    free(region_mfn);
> ...
>> +    pagebuf_free(&pagebuf);
> These look correct to me.
>
> But as regards
>
>> +    free(ctx->p2m_batch);
> It's not clear to me where that's initialised.  It needs to be
> initialised to NULL I think.
>
> Ian.

It is initialised in memset(ctx, 0, sizeof(*ctx)) at the top of the
function.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel