Re: [Xen-devel] [PATCH v3 1/2] libxl: Add "cpu-add" QMP command.

[George Dunlap <dunlapg@xxxxxxxxx>]

On Mon, Jun 24, 2013 at 2:32 PM, Anthony PERARD
<anthony.perard@xxxxxxxxxx> wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Looks fine to me:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

> ---
>  tools/libxl/libxl_internal.h |  2 ++
>  tools/libxl/libxl_qmp.c      | 21 +++++++++++++++++++++
>  2 files changed, 23 insertions(+)
>
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 3ba3a21..3e45b94 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1412,6 +1412,8 @@ _hidden int libxl__qmp_save(libxl__gc *gc, int domid, 
> const char *filename);
>  /* Set dirty bitmap logging status */
>  _hidden int libxl__qmp_set_global_dirty_log(libxl__gc *gc, int domid, bool 
> enable);
>  _hidden int libxl__qmp_insert_cdrom(libxl__gc *gc, int domid, const 
> libxl_device_disk *disk);
> +/* Add a virtual CPU */
> +_hidden int libxl__qmp_cpu_add(libxl__gc *gc, int domid, int index);
>  /* close and free the QMP handler */
>  _hidden void libxl__qmp_close(libxl__qmp_handler *qmp);
>  /* remove the socket file, if the file has already been removed,
> diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
> index 644d2c0..3d6dec6 100644
> --- a/tools/libxl/libxl_qmp.c
> +++ b/tools/libxl/libxl_qmp.c
> @@ -668,6 +668,18 @@ static void qmp_parameters_add_bool(libxl__gc *gc,
>      qmp_parameters_common_add(gc, param, name, obj);
>  }
>
> +static void qmp_parameters_add_integer(libxl__gc *gc,
> +                                       libxl__json_object **param,
> +                                       const char *name, const int i)
> +{
> +    libxl__json_object *obj;
> +
> +    obj = libxl__json_object_alloc(gc, JSON_INTEGER);
> +    obj->u.i = i;
> +
> +    qmp_parameters_common_add(gc, param, name, obj);
> +}
> +
>  #define QMP_PARAMETERS_SPRINTF(args, name, format, ...) \
>      qmp_parameters_add_string(gc, args, name, \
>                                libxl__sprintf(gc, format, __VA_ARGS__))
> @@ -929,6 +941,15 @@ int libxl__qmp_insert_cdrom(libxl__gc *gc, int domid,
>      }
>  }
>
> +int libxl__qmp_cpu_add(libxl__gc *gc, int domid, int index)
> +{
> +    libxl__json_object *args = NULL;
> +
> +    qmp_parameters_add_integer(gc, &args, "id", index);
> +
> +    return qmp_run_command(gc, domid, "cpu-add", args, NULL, NULL);
> +}
> +
>  int libxl__qmp_initializations(libxl__gc *gc, uint32_t domid,
>                                 const libxl_domain_config *guest_config)
>  {
> --
> Anthony PERARD
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel