Re: [Xen-devel] [PATCH 06/18] PVH xen: Introduce PVH guest type and some basic changes.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.06.13 at 03:14, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> On Tue, 25 Jun 2013 10:01:23 +0100 "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> >>> On 25.06.13 at 02:01, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>> > --- a/xen/include/xen/sched.h
>> > +++ b/xen/include/xen/sched.h
>> > @@ -238,6 +238,14 @@ struct mem_event_per_domain
>> >      struct mem_event_domain access;
>> >  };
>> >  
>> > +/*
>> > + * PVH is a PV guest running in an HVM container. While is_hvm_*
>> > checks are
>> > + * false for it, it uses many of the HVM data structs.
>> > + */
>> > +enum guest_type {
>> > +    is_pv, is_pvh, is_hvm
>> 
>> Pretty odd names for enumerators - it's more conventional for them
>> to have a prefix identifying their enumeration type in some way.
> 
> Ok, which is better: 
> 
>          guest_is_pv, guest_is_pvh, guest_is_hvm
> or
>          guest_type_is_pv, guest_type_is_pvh, guest_type_is_hvm
> or
>          dom_is_pv, dom_is_pvh, dom_is_hvm    (change enum to domain_type)

         guest_type_pv, guest_type_pvh, guest_type_hvm
or
         dom_pv, dom_pvh, dom_hvm    (change enum to domain_type)

Are both fine with me - I mainly dislike the "is" in the names, as
to me that's only a sensible prefix or infix for a function or macro
testing a property.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel