Re: [Xen-devel] [PATCH] also override library path for hotplug scripts

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-06-25 at 15:12 +0100, Jan Beulich wrote:
> Overriding PATH but not LD_LIBRARY_PATH is bogus, as it may result in
> the use of mismatched binaries and libraries.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

George, opinion RE 4.3? I think it should be pretty safe.

> 
> --- a/tools/hotplug/Linux/xen-hotplug-common.sh
> +++ b/tools/hotplug/Linux/xen-hotplug-common.sh
> @@ -31,6 +31,7 @@ dir=$(dirname "$0")
>  exec 2>>/var/log/xen/xen-hotplug.log
>  
>  export 
> PATH="${BINDIR}:${SBINDIR}:${LIBEXEC}:${PRIVATE_BINDIR}:/sbin:/bin:/usr/bin:/usr/sbin:$PATH"
> +export LD_LIBRARY_PATH="${LIBDIR}${LD_LIBRARY_PATH+:}$LD_LIBRARY_PATH"
>  export LANG="POSIX"
>  unset $(set | grep ^LC_ | cut -d= -f1)
>  
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel