Re: [Xen-devel] [PATCH] Fix assignment of devid value returned from libxl__device_nextid

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-06-26 at 10:41 +0100, George Dunlap wrote:
> On Tue, Jun 25, 2013 at 11:02 PM, Jim Fehlig <jfehlig@xxxxxxxx> wrote:
> > Commit 5420f265 has some misplaced parenthesis that caused devid
> > to be assigned 1 or 0 based on checking return value of
> > libxl__device_nextid < 0, e.g.
> >
> >   devid = libxl__device_nextid(...) < 0
> >
> > This works when only one instance of a given device type exists, but
> > subsequent devices of the same type will also have a devid = 1 if
> > libxl__device_nextid succeeds.  Fix by checking the value assigned to
> > devid, e.g.
> >
> >   (devid = libxl__device_nextid(...)) < 0

This is why I hate combined assignment & logic!

> >     Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> 
> Both for 4.3, and as a patch in general:
> 
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Acked + applied, thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel