[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] pygrub/GrubConf: fix boot problem for fedora 19 grub.cfg (2nd attempt)

On Wed, Jun 26, 2013 at 02:52:05PM +0100, George Dunlap wrote:
> On Mon, Jun 24, 2013 at 5:21 PM, Marcel J.E. Mol <marcel@xxxxxxx> wrote:
> > Booting a fedora 19 domU failed because a it could not properly
> > parse the grub.cfg file. This was cased by
> >
> >         set default="${next_entry}"
> >
> > This statement actually is within an 'if' statement, so maybe it would
> > be better to skip code within if/fi blocks...
> > But this patch seems to work fine.
> >
> > Signed-off-by: Marcel Mol <marcel@xxxxxxx>
> Thanks Marcel -- is this in a default and/or auto-generated Fedora
> grub.cfg, or was this something you put in manually?

Yes, it is auto generated, with all the defaults installing a new
kernel will recreate the grub.cfg file.

> In any case, I think it's a bit too late for 4.3 -- there's too much
> risk that this might break something else; and there has been over two
> months of RCs where Fedora users could have reported this bug.  It
> will have to wait until 4.4 / 4.3.1.
> If this is part of a default instal, however, we should probably add a
> release note to that effect.

It is quite a harmless patch. I wonder if it could break anything as
pygrub does not seem to evaluate $variable in a grub.cfg file
(correct me if I'm wrong...)

     ======--------         Marcel J.E. Mol                MESA Consulting B.V.
    =======---------        ph. +31-(0)6-54724868          P.O. Box 112
    =======---------        marcel@xxxxxxx                 2630 AC  Nootdorp
__==== www.mesa.nl ---____U_n_i_x______I_n_t_e_r_n_e_t____ The Netherlands ____
 They couldn't think of a number,           Linux user 1148  --  counter.li.org
    so they gave me a name!  -- Rupert Hine  --  www.ruperthine.com

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.