Re: [Xen-devel] [PATCH 05/10] kexec: extend hypercall with improved load/unload ops

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 25/06/13 19:52, Daniel Kiper wrote:
> On Mon, Jun 24, 2013 at 06:42:16PM +0100, David Vrabel wrote:
>> 
>> +        .globl __kexec_reloc_size
>> +        .set __kexec_reloc_size, . - kexec_reloc
>> +        .globl kexec_reloc_size
>> +kexec_reloc_size:
>> +        .quad __kexec_reloc_size
> 
> Why do you define two variables to store the same value?
> 
>   .globl kexec_reloc_size /* Personaly I prefer do this at the beginning of S 
> file. */
> kexec_reloc_size:
>   .long . - xen_relocate_kernel
> 
> It should work for C files and linker script.

This doesn't work, to the linker the value of kexec_reloc_size is its
address.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel